feat(state): Safely added ability to disable semicolons #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
==========================================
- Coverage 95.45% 95.36% -0.09%
==========================================
Files 1 1
Lines 550 561 +11
==========================================
+ Hits 525 535 +10
- Misses 25 26 +1
Continue to review full report at Codecov.
|
davidbonnet
requested changes
Jul 14, 2019
There was a problem hiding this comment.
Thanks @Mouradif for suggesting these changes.
Quickly added some tests that stress the semicolon placement algorithm. Suggested approach is to have a special write method used in places where one of these characters is inserted: '[(+-'.
Note also that writeToStream, writeAndMap, and writeToStreamAndMap should apply the same logic, thus requiring perhaps a formatCode method to be used in all three.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followed @eddiesholl 's advice for the
state.terminate()method in this comment : #20 (comment)as well as @davidbonnet 's warning on sensitive characters and on that, I followed instructions from eslint where the semicolon would be put right before a
(,[or a-on the next statementfix #20