Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment of return value of 'OnItemClickListener.onItemClick()' may mislead. #762

Open
tankpow opened this issue Jun 10, 2020 · 0 comments
Open

Comments

@tankpow
Copy link

tankpow commented Jun 10, 2020

Return value of 'OnItemClickListener.onItemClick()' is commented as:

  • @return true if the click should activate the itemView according to the selection mode,
  • false for no change to the itemView.

But 'OnItemClickListener.onItemClick()' is only used in 'FlexibleViewHolder.onClick()', which uses this return value to determine whether to toggle activation.

Is is proper to change comment to something like "return true if the click should toggle activation of itemView"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant