Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for mypy_extensions.TypedDict #23

Open
davidfstr opened this issue Dec 23, 2023 · 1 comment
Open

Drop support for mypy_extensions.TypedDict #23

davidfstr opened this issue Dec 23, 2023 · 1 comment
Milestone

Comments

@davidfstr
Copy link
Owner

davidfstr commented Dec 23, 2023

Why:

  • This kind of TypedDict was introduced in the era of Python 3.7, which is no longer supported by trycast.
    • It is reasonable (in @davidfstr 's opinion) to encourage other users to migrate to a version of TypedDict from the standard library (Python 3.9+) or from typing_extensions (Python 3.8).
  • Extra code is required to support this very old kind of TypedDict.

Timing:

  • Suggest actually dropping mypy_extensions.TypedDict support at the same time as dropping support for Python 3.8, because then the trycast(strict=...) parameter (which involves both Python 3.8's TypedDict and mypy_extensions.TypedDict, and nothing else) can be cleanly removed simplified at the same time
@davidfstr
Copy link
Owner Author

mypy_extensions.TypedDict was deprecated in Aug 2023, according to python/mypy_extensions#46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant