Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support React 18 #463

Closed
nikeee opened this issue Mar 29, 2022 · 9 comments
Closed

Support React 18 #463

nikeee opened this issue Mar 29, 2022 · 9 comments

Comments

@nikeee
Copy link
Contributor

nikeee commented Mar 29, 2022

React 18 released:
https://github.com/facebook/react/releases/tag/v18.0.0

Is this library compatible with React 18 despite the warning that's currently printed when installing react-spinners?

@adrianmanduc
Copy link

Any update on this ?

@RubenVerster
Copy link

RubenVerster commented Apr 9, 2022

Use this, please
npm install --save react-spinners --legacy-peer-deps

You might have to run this as well
npm i react-dom --legacy-peer-deps

And just to be safe, run
npm i

Do you guys like not google or check your consoles or something...

@nikeee
Copy link
Contributor Author

nikeee commented Apr 10, 2022

Yes, that might work. However, as seen in your instructions, --legacy-peer-deps uses a legacy mode, which should be avoided.
Fixing this upstream would be appropriate.

There is a PR for upgrading the dependency: #464

@davidhu2000
Copy link
Owner

try 0.12.0-alpha.3 and see if the issue is resolved

@davidhu2000
Copy link
Owner

oof, this might be more compcliated than expected given enzyme doesn't have an adapter for react 18

@RubenVerster
Copy link

Yes, that might work. However, as seen in your instructions, --legacy-peer-deps uses a legacy mode, which should be avoided. Fixing this upstream would be appropriate.

There is a PR for upgrading the dependency: #464

I know man... but this is the current fix for the issue right now
Once the PR has been merged in, they will come and tell us that the issue has an official fix :P

@aperalta1431
Copy link

I appreciate the above solution but it should be avoided. Besides the above solution involves making changes to the pipeline to support such legacy mode if we still want to proceed with it which is not suitable in an enterprise setting. Nonetheless, the library is a time saver and I will be waiting for an update on this.

@Ali-Aref
Copy link

any updates ?

@davidhu2000
Copy link
Owner

davidhu2000 commented May 16, 2022

v0.12.0 is released with react 18 support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants