Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slides & container options #440

Closed
1 task done
davidjerleke opened this issue Mar 5, 2023 · 0 comments · Fixed by #441
Closed
1 task done

Add slides & container options #440

davidjerleke opened this issue Mar 5, 2023 · 0 comments · Fixed by #441
Labels
feature request New feature or request resolved This issue is resolved

Comments

@davidjerleke
Copy link
Owner

davidjerleke commented Mar 5, 2023

Feature request is related to

  • embla-carousel (core package)

Is your feature request related to an issue?

Describe the solution you'd like

  • Enable users to provide either selectors for container and/or slides, or passing HTML elements directly. For example, in some cases, users might want to put elements inside the slide container that aren't slides, like template elements or similar. At the time of writing, this breaks the carousel.

Examples

// Selector approach

const emblaApi = EmblaCarousel(rootNode, {
  container: '.embla__container',
  slides: '.embla__slide',
});

...or

// HTML element approach

const emblaApi = EmblaCarousel(rootNode, {
  container: document.querySelector('.embla__container'),
  slides: document.querySelectorAll('.embla__slide'),
});

Types

type container = string | HTMLElement | null;
type slides = string | HTMLElement[] | NodeListOf<HTMLElement> | null;
@davidjerleke davidjerleke added the feature request New feature or request label Mar 5, 2023
davidjerleke added a commit that referenced this issue Mar 5, 2023
@davidjerleke davidjerleke linked a pull request Mar 5, 2023 that will close this issue
@davidjerleke davidjerleke added the upcoming A feature or bug fix is on its way for this issue label Mar 7, 2023
davidjerleke added a commit that referenced this issue Mar 8, 2023
Add `slides` & `container` options
@davidjerleke davidjerleke added resolved This issue is resolved and removed upcoming A feature or bug fix is on its way for this issue labels Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request resolved This issue is resolved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant