Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FetchError: request to https://example.com/check failed, reason: certificate has expired #358

Open
holtwick opened this issue Oct 6, 2021 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@holtwick
Copy link

holtwick commented Oct 6, 2021

I run a custom instance of LanguageTool on Docker. It used to work fine. But now I get these errors from the plugin:

language: auto
motherTongue: de-DE
preferredVariants: en-US,de-DE
Error connecting to https://z-languagetool.holtwick.de/v2/check
FetchError: request to https://z-languagetool.holtwick.de/v2/check failed, reason: certificate has expired

The SSL certificate is up-to-date. Is there something I can do to fix this?

@holtwick holtwick added the bug Something isn't working label Oct 6, 2021
@davidlday
Copy link
Owner

So I did a little digging and came across this issue on node-fetch that might provide some insight: node-fetch/node-fetch#568

Looks like it might be an electron issue. I'm leaving this open for now and will try to do a little more digging over the weekend, but ultimately I don't think it's an issue with this extension specifically.

@holtwick
Copy link
Author

holtwick commented Oct 8, 2021

Thanks! Maybe it is worth updating node-fetch? It is on 3.0 now. https://www.npmjs.com/package/node-fetch

@davidlday
Copy link
Owner

Oh definitely. Dependabot already opened PR #328 for updating, but I have to make some significant changes to use it since it's changed to an ESM only package. I'm working through it, but it's slow going due to other life priorities.

@holtwick
Copy link
Author

The node-fetch people seem to also maintain the 2.x branch as well. Bumping to 2.6.5 might also solve the issue without larger rework? https://www.npmjs.com/package/node-fetch/v/2.6.5

@davidlday
Copy link
Owner

Updated to node-fetch 2.6.6. Still leaving the issue open for awareness.

@cernst72
Copy link

This is still happening in version 0.19.0:
The certificate is perfectly valid and working with other clients, but the extension's output says:
Error connecting to https://xx.yy.zz/v2/check
FetchError: request to https://xx.yy.zz/v2/check failed, reason: certificate has expired

@cernst72
Copy link

This is still happening in version 0.19.0: The certificate is perfectly valid and working with other clients, but the extension's output says: Error connecting to https://xx.yy.zz/v2/check FetchError: request to https://xx.yy.zz/v2/check failed, reason: certificate has expired

This is probably not related to vscode-languagetool-linter, but a general problem concerning letsencrypt certificates in vscode, as discussed here.
Setting "http.systemCertificates": false in settings.json works for me. So, not an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants