Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding default options breaks the Internet #60

Closed
dpodsiadlo opened this issue Sep 8, 2021 · 4 comments
Closed

Adding default options breaks the Internet #60

dpodsiadlo opened this issue Sep 8, 2021 · 4 comments

Comments

@dpodsiadlo
Copy link

Hi, in the latest release you're introducing defaultLimits which haven't existed before: v2.0.8...v2.1.0#diff-e727e4bdf3657fd1d798edcd6b099d6e092f8573cba266154583a746bba0f346R22

This might break the Internet because of superagent lib using safe-fast-stringify ^2.0.7 and not providing any limits to the stringify method.
@mcollina
Copy link
Collaborator

mcollina commented Sep 8, 2021

This was already fixed in #58

@mcollina mcollina closed this as completed Sep 8, 2021
@dpodsiadlo
Copy link
Author

Any plans on releasing the fix?

@mcollina
Copy link
Collaborator

mcollina commented Sep 8, 2021

I released it 1 hour ago.

@dpodsiadlo
Copy link
Author

thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcollina @dpodsiadlo