Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails when url doesn't contain exact version string #49

Open
davidchall opened this issue Dec 5, 2022 · 0 comments
Open

Fails when url doesn't contain exact version string #49

davidchall opened this issue Dec 5, 2022 · 0 comments

Comments

@davidchall
Copy link

Thanks for maintaining this GitHub Action - it's been very helpful!

I have a formula (see here) where the tarball url does not contain the periods from the version string. For example, the package version is 8.307 and the tarball url contains "8307". There are other formulae like this in homebrew-core (see here).

Running brew bump-formula-pr with only the --version argument attempts to update the URL using string substitution. Since the old url does not contain the old version string, it's unable to perform the substitution and so it cannot infer the new url. It raises the error You need to bump this formula manually since the new URL and old URL are both <old_url>.

Normally, the solution to this issue is to specify the --url argument. The difficulty for the GitHub Action is that we can't retrieve the new url from the livecheck command, so we can't automate this AFAIK.

Perhaps this underlying assumption should be documented? (i.e., URL must include version string exactly)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant