Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Resizable|Clippable|Scalable|Rotatable Options typings #1088

Open
SidIcarus opened this issue Feb 9, 2024 · 0 comments
Open

Bug: Resizable|Clippable|Scalable|Rotatable Options typings #1088

SidIcarus opened this issue Feb 9, 2024 · 0 comments

Comments

@SidIcarus
Copy link

Environments

  • Framework name: Vanilla JS
  • Moveable Component version: 0.53

Description

The ables resizable, clippable, scalable, & rotatable, each provide the typing: able?: boolean | AbleOptionsType within their AbleOptionsType. As it is a recursive definition, it includes the able: boolean again. I see why this was added (to differentiate same options between different ables, such as keepRatio. But able: AbleOptionsType always gets treated as able: true even when able: { able: false } is set. I believe if it is to be recursive, it should treat the the first depth able option as a boolean.

An alternative could be to do able: boolean and ableOptions: AbleIOptionsType so you dont have to deal with the option of recursion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant