Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle get container registry record error #455

Closed
vedranjukic opened this issue May 2, 2024 · 2 comments · Fixed by #633
Closed

Handle get container registry record error #455

vedranjukic opened this issue May 2, 2024 · 2 comments · Fixed by #633
Assignees
Labels
bug Something isn't working never stale An issue that never goes stale

Comments

@vedranjukic
Copy link
Member

In https://github.com/daytonaio/daytona/blob/main/pkg/server/workspaces/create.go#L89 the error is ignored.

The error should be ignored only on the "not found" error, otherwise, it should return the error.

@Tpuljak
Copy link
Member

Tpuljak commented May 2, 2024

We should implement the "RecordNotFound" error in all stores to standardize this.

@Tpuljak Tpuljak self-assigned this May 2, 2024
@daytonaBot
Copy link
Collaborator

This Issue has been automatically marked as "stale" because it has not had recent activity (for 14 days). It will be closed if no further activity occurs. Thanks for the feedback.

@Tpuljak Tpuljak added bug Something isn't working never stale An issue that never goes stale and removed Stale labels May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working never stale An issue that never goes stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants