Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: start stop messages #570

Merged
merged 2 commits into from
May 17, 2024
Merged

fix: start stop messages #570

merged 2 commits into from
May 17, 2024

Conversation

idagelic
Copy link
Member

Start stop messages

Description

Minor UX fixes

  • Changes daytona start / daytona stop message from "Workspace started" to "Workspace start request submitted"

  • Fixes single project start/stop commands response from "Workspace started" to "Project x from workspace y started"

  • Fixed daytona start --all prompting the user for a workspace once they are all started

  • daytona start/stop -p projectName now displays the help instead of prompting because of the incorrect command format

  • This change requires a documentation update

  • I have made corresponding changes to the documentation

Related Issue(s)

Closes #492

Screenshots

If relevant, please add screenshots.

Notes

Please add any relevant notes if necessary.

Signed-off-by: Ivan Dagelic <dagelic.ivan@gmail.com>
@idagelic idagelic requested a review from a team as a code owner May 16, 2024 14:59
@vedranjukic
Copy link
Member

I would change the message to "Workspace starting"

Signed-off-by: Ivan Dagelic <dagelic.ivan@gmail.com>
@idagelic idagelic merged commit 0ccdb7a into main May 17, 2024
11 checks passed
@idagelic idagelic deleted the start-stop-messages branch May 17, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

daytona stop -p doesn't work
3 participants