Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support header links #30

Closed
alallier opened this issue Jul 21, 2017 · 6 comments
Closed

Support header links #30

alallier opened this issue Jul 21, 2017 · 6 comments

Comments

@alallier
Copy link
Contributor

Support header based URL links, like GitHub, GitLab, and VSCode markdown preview support.

This is nice for testing table of contents and links to specific parts of the README

GitHub

githubheadersupport

VSCode

vscodeheadersupport

@alallier
Copy link
Contributor Author

Seems like this is the relevant issue on markdown-it's side markdown-it/markdown-it#28

@alallier
Copy link
Contributor Author

alallier commented Jul 21, 2017

Seems there are some plugins written to support my idea...

https://github.com/leff/markdown-it-named-headers
https://github.com/adam-p/markdown-it-headinganchor
https://github.com/medfreeman/markdown-it-toc-and-anchor

Willing to work on a PR for this if you will support this ability

@dbankier
Copy link
Owner

@alalier, would be great to have a PR. The screenshots however are of vscode's in built markdown viewer. This plugin is used to open the preview (running on a different code base) in a browser.

@alallier
Copy link
Contributor Author

Right yep I know was just showing that both VSCode and GitHub support this behavior. Will work on a PR soon!

@dbankier
Copy link
Owner

Thanks. Sorry I jumped in. I have people that have confused this plugin with the vscode feature.

@alallier
Copy link
Contributor Author

alallier commented Jul 24, 2017

Yep no problem always good to clarify. Love the extension and want to add on. Should have it up soon hopefully.

dbankier added a commit that referenced this issue Aug 19, 2017
Added header ids to be used for linking (Closes #30)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants