Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong username when the project name is > 1 word #33

Open
samkahchiin opened this issue Mar 16, 2023 · 1 comment
Open

Wrong username when the project name is > 1 word #33

samkahchiin opened this issue Mar 16, 2023 · 1 comment

Comments

@samkahchiin
Copy link
Contributor

samkahchiin commented Mar 16, 2023

      let [project, env] = i.DBInstanceIdentifier.split('-')

      let username = env ? `${project}_${env}_readonly` : '-'

Currently, the apps expect the project name will only consist of one word, if it is more than one word, it will generate the wrong db username

eg. if the db identifier name is google-drive-staging,

it will thought the project name is google, and env name is drive
therefore the username will be
google_drive_readonly

but the user would expect the username to be
google_drive_staging_readonly

https://github.com/dbl-works/rds-manager/blob/d8cb34dc0d75fe593ceed16ba3e63d59782831ac/src/renderer/rds_manager.js#L18

@samkahchiin samkahchiin changed the title Wrong username when the DB name is split by - Wrong username when the project name is > 1 word Mar 16, 2023
@swiknaba
Copy link
Contributor

to test if this is still an issue in the Rust rewrite, or if that was a bug in the previous JS version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants