Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move documentation from crate root to macro? #16

Open
kangalio opened this issue Sep 4, 2021 · 1 comment · May be fixed by #17
Open

Move documentation from crate root to macro? #16

kangalio opened this issue Sep 4, 2021 · 1 comment · May be fixed by #17

Comments

@kangalio
Copy link

kangalio commented Sep 4, 2021

This would be convenient for crates which re-export the async_recursion macro, like frameworks whose users need an async_recursion-like macro to function (e.g. to store async functions and closures in a struct).

If the documentation on the macro were on the macro directly, the re-export in dependent crates would show that documentation as well.

@dcchut dcchut linked a pull request Sep 5, 2021 that will close this issue
@dcchut
Copy link
Owner

dcchut commented Sep 5, 2021

This seems reasonable to me - I've put up #17 to add usage documentation on the macro function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants