Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: ensure CLR calculations are saturated #492

Open
thelostone-mc opened this issue Nov 9, 2021 · 1 comment
Open

bug: ensure CLR calculations are saturated #492

thelostone-mc opened this issue Nov 9, 2021 · 1 comment
Assignees
Labels
bug Something isn't working dcurve GR12 Scoped for the GR12 Grant Round release
Projects

Comments

@thelostone-mc
Copy link
Collaborator

thelostone-mc commented Nov 9, 2021

Describe the bug

  • Right now assume if the round has excess funds of 1000 DAI
  • When run the CLR distribution , the total amount to be sent is 700 DAI

We have a surplus of 300 DAI as the round hasn't been saturated
Ideally we'd want to ensure on making payouts -> the CLR calculations should be saturated AKA ALWAYS 1000 DAI should be sent

@thelostone-mc thelostone-mc added bug Something isn't working dcurve GR12 Scoped for the GR12 Grant Round release labels Nov 9, 2021
@phutchins phutchins added this to To Do in dGrants Nov 10, 2021
@gdixon
Copy link
Member

gdixon commented Dec 9, 2021

This still needs solving, but the GR12 round is now saturated and we wont see a repeat of this bug when we come to generate the payouts:

32.78 + 28.22 + 36.24 + 18.8 + 15.12 + 83.28 + 51.02 + 4548.36 + 6124.25 + 1878.08 + 3325.93 + 2938.26 + 2944.35 + 3282.56 = 25307.25

@phutchins phutchins moved this from To Do to Ready for Review in dGrants Jan 13, 2022
@phutchins phutchins moved this from Ready for Review to Backlog in dGrants Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dcurve GR12 Scoped for the GR12 Grant Round release
Projects
dGrants
Backlog
Development

No branches or pull requests

2 participants