Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Walletconnect throwing error #555

Closed
metafraction opened this issue Dec 1, 2021 · 4 comments · Fixed by #564
Closed

Walletconnect throwing error #555

metafraction opened this issue Dec 1, 2021 · 4 comments · Fixed by #564
Assignees
@metafraction
Labels
app Frontend issues bug Something isn't working GR12 Scoped for the GR12 Grant Round release

Comments

@metafraction
Copy link
Member

metafraction commented Dec 1, 2021 •
edited

When connecting with walletconnect, it throws the following error

Screen Shot 2021-12-01 at 2 24 06 PM
@metafraction metafraction added app Frontend issues bug Something isn't working labels Dec 1, 2021
@apbendi apbendi added the GR12 Scoped for the GR12 Grant Round release label Dec 2, 2021
@metafraction metafraction self-assigned this Dec 2, 2021
@metafraction
Copy link
Member Author

metafraction commented Dec 3, 2021 •
edited

It seems require is in node and not supported client side - although, there are options like require.js or browserify if we want to support it

@mds1
Copy link
Contributor

mds1 commented Dec 3, 2021 •
edited

This is a vite-specific issue—it's a modern build tool and doesn't use the older require syntax. When packages use require, we basically have to polyfill it with something like this: https://github.com/originjs/vite-plugins/tree/main/packages/vite-plugin-commonjs

See this issue fore more info: vitejs/vite#3409 (not sure why it only happens with WC though)

@mds1
Copy link
Contributor

mds1 commented Dec 3, 2021

Ah this seems more relevant to us: vitejs/vite#4593

@mds1 mds1 mentioned this issue Dec 3, 2021
Merged
@metafraction
Copy link
Member Author

metafraction commented Dec 3, 2021 •
edited

@mds1 ^ ah yeah that does seem more relevant - although, not sure how he resolved the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metafraction metafraction

Labels
app Frontend issues bug Something isn't working GR12 Scoped for the GR12 Grant Round release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: 'require is not defined' on prod for walletconnect dcgtc/dgrants
3 participants
@apbendi @mds1 @metafraction