Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add correct link for name in contributions #597

Open
metafraction opened this issue Dec 16, 2021 · 0 comments
Open

Add correct link for name in contributions #597

metafraction opened this issue Dec 16, 2021 · 0 comments
Assignees
@metafraction
Projects
dGrants

Comments

@metafraction
Copy link
Member

metafraction commented Dec 16, 2021 •
edited

We are using the ContributionDetail.vue component for both grant contributions as well as matchingPool contributions. The link in the name links to the homepage. We need the correct link for each.

We can create a link field inside ContributionsDetail to handle this.

link for grant contribution: :href="'#/dgrants/' + contribution.grantId"
link for matchingPool contribution: :href="'#/dgrants/rounds' + contribution.grantAddress"
@metafraction metafraction mentioned this issue Dec 16, 2021
Merged
@metafraction metafraction self-assigned this Dec 17, 2021
@phutchins phutchins added this to Backlog in dGrants Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metafraction metafraction

Labels
None yet
Projects
dGrants
Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@metafraction