Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registry: decide on architecture for grant creation + flow of donation funds #613

Open
Tracked by #600
mds1 opened this issue Jan 13, 2022 · 0 comments
Open
Tracked by #600
Assignees
Labels
protocol Related to finalizing a protocol specification
Projects

Comments

@mds1
Copy link
Contributor

mds1 commented Jan 13, 2022

These are coupled, so putting them into the same issue

There are two ways donations can be handled:

  1. Donations are sent to a grant owner's address as part of the donation transaction
  2. Donations are sent to a FundManager type of contract, which is single contract that holds all funds and provides a claim() method for grant owners to claim their donations

There are three main ideas we currently have on what grant creation could look like. All can be combined with both donation flows above:

  1. An incrementing grant ID that maps to a struct containing a payout address (this is the current approach used by POC, and it has the downside of being very inefficient and costly, since you need a storage read for every payout address)
  2. Deploy a proxy wallet (see Discuss: Use a grant's `payee` address as it's ID #54), where the proxy wallet address is the grant ID. This is nice because the grant ID is the payout address, but has the downside of making it costlier to enumerate all grants on-chain
  3. Deploy an NFT, where the holder is the grant owner

I currently lean towards the combination of donation flow 2 + grant creation 3, because:

However, a bit more research/thinking on the tradeoffs is needed before making a decision

@mds1 mds1 added the protocol Related to finalizing a protocol specification label Jan 13, 2022
@mds1 mds1 changed the title Decide on architecture for grant creation + flow of donation funds registry: decide on architecture for grant creation + flow of donation funds Jan 13, 2022
@mds1 mds1 self-assigned this Jan 14, 2022
@phutchins phutchins added this to To Do in dGrants Jan 18, 2022
@phutchins phutchins moved this from To Do to Doing in dGrants Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol Related to finalizing a protocol specification
Projects
dGrants
Doing
Development

No branches or pull requests

1 participant