New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enumerable strings to unions #86

Open

johngeorgewright opened this issue May 10, 2024 · 0 comments

johngeorgewright commented May 10, 2024 •

edited

I'd like to suggest that enumerable strings be converted to unions.

For example:

<!-- ... -->
<element maxOccurs="1" minOccurs="0" name="adUnitView" type="tns:AdUnitView"/>
<!-- ... -->
<simpleType name="AdUnitView">
  <restriction base="xsd:string">
    <enumeration value="TOP_LEVEL"/>
    <enumeration value="FLAT"/>
    <enumeration value="HIERARCHICAL"/>
  </restriction>
</simpleType>

Would become:

  /** AdUnitView|xsd:string */
  adUnitView?: 'TOP_LEVEL' | 'FLAT' | 'HIERARCHICAL'

Rather than the current implementation:

  /** AdUnitView|xsd:string|TOP_LEVEL,FLAT,HIERARCHICAL */
  adUnitView?: string

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment