Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add vim bindings #190

Closed
busla opened this issue Mar 13, 2024 · 2 comments
Closed

feature: add vim bindings #190

busla opened this issue Mar 13, 2024 · 2 comments

Comments

@busla
Copy link

busla commented Mar 13, 2024

It would be great for us transitioning from fzf to get the following features:

  1. VIM bindings for item navigation
  2. Override item navigationhishtory keybindings.

fzf bindings:

  • ctrl+k: up
  • ctrl+j: down

Since hishtory binds ctrl+k to delete item, overriding that would be a requirement for adopting VIM bindings.

related: #55

@ddworken
Copy link
Owner

Thanks for filing this! The core code for this is actually already in place since we already use a keymap to store configurable key bindings, it just isn't wired up to the config to enable actually customizing this. I'll try to take this on relatively soon, but if anyone is looking to make a contribution, I think this could be a good starter one. :)

ddworken added a commit that referenced this issue Apr 28, 2024
* Add support for custom key bindings for #190

* Add tests for configuring custom key bindings

* Simplify key bindings test

* Add docs on custom key bindings + error message for unhandled actions
@ddworken
Copy link
Owner

ddworken commented Jun 2, 2024

This is now fully released and available, if you run hishtory update you can now customize the key bindings. Check out the README for information on how to do this. If you run into any issues, please re-open this issue to let me know. :)

@ddworken ddworken closed this as completed Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants