Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config option to exclude commands with non-zero exit codes #76

Open
d4v3y0rk opened this issue Feb 21, 2023 · 1 comment
Open

Add config option to exclude commands with non-zero exit codes #76

d4v3y0rk opened this issue Feb 21, 2023 · 1 comment

Comments

@d4v3y0rk
Copy link

I don't know about other people but I often mistype a command and end up having to run it again. It would be nice to have the opt-in ability to not store commands with non-zero exit codes.
@ddworken ddworken changed the title Add the ability to filter out commands with a non zero exit code Add config option to exclude commands with non-zero exit codes Feb 24, 2023
@ddworken
Copy link
Owner

Interesting! I think this is a reasonable FR. Though for the record, this is already somewhat possible by just search for exit_code:0 to filter to entries with an exit code of 0.

ddworken added a commit that referenced this issue Dec 31, 2023
@ddworken
Add ability to configure a default filter (for #76)
13beb9c
ddworken added a commit that referenced this issue Jan 8, 2024
@ddworken
Add ability to configure a default filter (for #76) (#161)
a3f1282 
* Add ability to configure a default filter (for #76)

* Add test for color of default filter

* Add basic test for default filter

* Add goldens for tests

* Add more tests for default filters

* Update goldens

* Add another golden

* Update goldens

* Remove debug log

* Add golden to allowlist

* Update goldens
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@d4v3y0rk @ddworken