Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: performance issue #625

Merged
merged 1 commit into from Oct 10, 2018
Merged

fix: performance issue #625

merged 1 commit into from Oct 10, 2018

Conversation

gxcsoccer
Copy link

image

gxcsoccer
gxcsoccer commented Oct 9, 2018
View reviewed changes
src/common.js
// Disabled?
if (!debug.enabled) {
return;
}

for (var _len = arguments.length, args = new Array(_len), _key = 0; _key < _len; _key++) {
args[_key] = arguments[_key];
}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not run if debug is disabled

@fengmk2
Copy link
Contributor

fengmk2 commented Oct 9, 2018

LGTM

@Qix-
Copy link
Member

Qix- commented Oct 9, 2018

Does this exist in master, too?

@Qix- Qix- added the awaiting-response This issue or pull request is awaiting a user's response label Oct 9, 2018
@gxcsoccer
Copy link
Author

Does this exist in master, too?

@Qix- master is ok

@Qix-
Copy link
Member

Qix- commented Oct 9, 2018

Don't worry about tests btw. I'll take a look at this a bit closer in a little while.

@Qix- Qix- added bug This issue identifies a malfunction change-patch This proposes or provides a change that requires a patch release and removed awaiting-response This issue or pull request is awaiting a user's response labels Oct 10, 2018
@Qix- Qix- merged commit f312a89 into debug-js:hotfix-3.2.2 Oct 10, 2018
@Qix-
Copy link
Member

Qix- commented Oct 10, 2018

Released as debug@3.2.6.

@gxcsoccer gxcsoccer deleted the fix-prof-issue branch October 23, 2018 11:52
@snyk-bot snyk-bot mentioned this pull request Sep 23, 2019
Closed
This was referenced Oct 17, 2019
Open
Open
Open
Open
Open
Open
Open
This was referenced Oct 24, 2019
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Oct 27, 2019
Open
Open
Open
This was referenced Nov 11, 2019
Open
Merged
This was referenced Nov 19, 2019
Open
Open
@snyk-bot snyk-bot mentioned this pull request Dec 5, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Dec 18, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Feb 28, 2020
Merged
This was referenced Mar 6, 2020
Open
Open
@snyk-bot snyk-bot mentioned this pull request Mar 17, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 3, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qix- Qix- Qix- approved these changes

Assignees
No one assigned
Labels
bug This issue identifies a malfunction change-patch This proposes or provides a change that requires a patch release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gxcsoccer @fengmk2 @Qix-