Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exporting the JsonWebKey interface #125

Closed
bshambaugh opened this issue Mar 28, 2022 · 2 comments
Closed

Exporting the JsonWebKey interface #125

bshambaugh opened this issue Mar 28, 2022 · 2 comments
Labels
enhancement New feature or request released

Comments

@bshambaugh
Copy link
Contributor

Is there any reason why the JsonWebKey interface is not exported? I know it was used internally. but could it be?

https://github.com/decentralized-identity/did-resolver/blob/master/src/resolver.ts#L74-L86
@bshambaugh bshambaugh added the enhancement New feature or request label Mar 28, 2022
@bshambaugh bshambaugh mentioned this issue Mar 28, 2022
Merged
@mirceanis
Copy link
Member

There's no specific reason other than wanting to minimise the exported API, to reduce the maintenance burden.
Besides this, the JsonWebKey defined here intentionally only refers to the public parts of a JWK, to discourage the use and leaking of private keys in DID documents.

We can close this after merging your PR #126

uport-automation-bot pushed a commit that referenced this issue Mar 29, 2022
@semantic-release-bot
chore(release): 3.2.0 [skip ci]
9fe7a43 
# [3.2.0](3.1.5...3.2.0) (2022-03-29)

### Features

* export JsonWebKey Interface ([#126](#126)) ([519c8bd](519c8bd)), closes [#125](#125)
@uport-automation-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mirceanis @bshambaugh @uport-automation-bot