Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with the footer and pages/themes #12574

Closed
2 tasks
paarals opened this issue Mar 6, 2024 · 9 comments · Fixed by #12592
Closed
2 tasks

Problems with the footer and pages/themes #12574

paarals opened this issue Mar 6, 2024 · 9 comments · Fixed by #12592
Assignees
Labels

Comments

@paarals
Copy link

paarals commented Mar 6, 2024

Describe the bug

Firstly, I see that there are twice the Terms of Use and Conditions:
imatge

I can remove one, if I go to the Terms of use and conditions page and uncheck the "show in the footer" checkbox.
imatge

On the other hand, when I am in this pages module, I want to put a theme to show the footer and it doesn't work.
imatge

To Reproduce

  1. Go to https://nightly.decidim.org/
  2. See error in the footer (double terms of service)
  3. Try to add a new item in the footer as themes https://nightly.decidim.org/admin/static_pages/help/edit
  4. See that is not apply

Expected behavior

If the terms of use page is to be permanent, remove the option at https://nightly.decidim.org/admin/static_pages/terms-of-service/edit to deselect it from appearing in the footer and do not fold the item.

  • Fix TandC

If I set any item page or theme as "show the footer" that works like version 0.27

  • Fix show in the footer for themes

Screenshots

No response

Stacktrace

No response

Extra data

Additional context

We validated this bug because it happens in our customer: https://capitalofdemocracy.barcelona/?locale=en

@greenwoodt
Copy link
Contributor

greenwoodt commented Mar 12, 2024

Hi @paarals thanks for reporting bug!

I can confirm I see both Default title for Terms of service AND Terms and Conditions directing me to the same path /pages/terms-of-service.

I can remove either one to allow (perhaps Terms and Conditions) due to the latter being labelled as is on purpose in the seeds.

Regarding the pages being present in the footer after clicking the button show in footer I can confirm pages are created which are found in Help but not present in the footer.

If @andreslucena and @carolromero wish to add anything to my comments, I could go ahead and try fix this issue?

@greenwoodt greenwoodt self-assigned this Mar 12, 2024
@andreslucena
Copy link
Member

I can remove either one to allow (perhaps Terms and Conditions) due to the latter being labelled as is on purpose in the seeds.

I just remember about this #10614 - so the preferred term should be "Terms of service"

@greenwoodt
Copy link
Contributor

I can remove either one to allow (perhaps Terms and Conditions) due to the latter being labelled as is on purpose in the seeds.

I just remember about this #10614 - so the preferred term should be "Terms of service"

Gotcha!

@greenwoodt
Copy link
Contributor

greenwoodt commented Mar 14, 2024

Adding @carolromero here for some feedback on the best approach for this functionality.

Myself and @andreslucena were investigating this issue further.

Currently a cell (decidim-core/app/cells/decidim/footer_pages_cell.rb) on line 9 of decidim-core/app/views/layouts/decidim/footer/_main.html.erb is being used to render a new functionality to allow newly created Pages ONLY to appear with assigned Topics, rending in a new coloumn to the footer on the right hand side. See image below:

Screenshot 2024-03-14 at 15 43 44

The current functionality in 0.27-stable allows users to create and publish a Page to the front end without an assigned Topic. As you can see if the page doesn't a topic it does appear. See images below:

admin:
Screenshot 2024-03-14 at 15 45 59

front-end footer:
Screenshot 2024-03-14 at 15 47 49

My idea here was to create a partial within decidim-core/app/views/layouts/decidim/footer that would inherit a condition to iterate any pages created under the organisation to appear in the footer.

OR

We can inject <%= cell("decidim/footer_pages", :topics) %> on to a new line but only instead of using :topics we could use the :pages method.

Keen to get your thoughts @carolromero on how to proceed with the changes to this?

@carolromero
Copy link
Member

@greenwoodt thanks for the ping! I'd go with the most flexible solution, which is what we already had, and not mix things up.
There are pages, which can be grouped (or not) in topics.
Then you can decide, independently of that, whether a particular page is shown in the footer.

@carolromero
Copy link
Member

carolromero commented Mar 15, 2024

After talking offline, we agreed to make the following changes:

  • Remove "Help" link in the footer from the "Decidim" column:
    image

  • Arrange three columns (and four sections) with the following distribution:
    image

Looking at the most common use case and taking the example of Decidim Barcelona, we will show under the "Help" column the first page of each topic:

  • Remove "show in footer" checkbox for pages. Leave the checkbox only for topics.
  • Rename column header from "General Help" to "Help"
  • Rename topic name from "General Help" to "General"

@greenwoodt

This comment was marked as resolved.

@greenwoodt
Copy link
Contributor

@carolromero I wanted to get your feedback on my new proposed arranged of the column arrangement taking into account the margin of space to the right of the whole footer? See the new proposed outlook below withe newly generated topic to te right:

Screenshot 2024-05-08 at 16 17 42

Previously proposed solution:
313157765-9a3fbeb6-22d5-4303-8efb-0d828cb955af

Let me know your thoughts!

@carolromero
Copy link
Member

@greenwoodt In all honesty I don't remember why we proposed to leave only 3 columns. Personally, I think your proposal works very well and it is responsive. So go ahead with it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants