Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename populate_help.rb to static_pages_seeds.rb #12842

Open
greenwoodt opened this issue May 9, 2024 · 2 comments · May be fixed by #12852
Open

Rename populate_help.rb to static_pages_seeds.rb #12842

greenwoodt opened this issue May 9, 2024 · 2 comments · May be fixed by #12852
Assignees
Labels
module: system type: change PRs that implement a change for an existing feature

Comments

@greenwoodt
Copy link
Contributor

greenwoodt commented May 9, 2024

Describe the bug

Finding the command that seeds the creation of static_pages and static_page_topics into Decidim was difficult because of a not useful nor appropriate name to the system command.

I'd like to suggest making a change to this file for future reference and changes to the Decidim pages.

Related to Footer Revamp PR: https://github.com/decidim/decidim/pull/12592/files

To Reproduce

Find decidim-system/app/commands/decidim/system/populate_help.rb

Expected behavior

A more appropriate and useful name to the file which essentially seeds Decidim pages. Such as static_pages_seeds.

Screenshots

No response

Stacktrace

No response

Extra data

  • Device: MACBOOK PRO 2020 M1
  • Device OS: Sosuma 14.4.1
  • Browser: FIREFOX
  • Decidim Version: 0.29 develop branch
  • Decidim installation: Decidim App

Additional context

No response

@greenwoodt greenwoodt added module: system type: change PRs that implement a change for an existing feature labels May 9, 2024
@greenwoodt
Copy link
Contributor Author

@andreslucena let me know your thoughts and I'll make the change

@andreslucena
Copy link
Member

A more appropriate and useful name to the file which essentially seeds Decidim pages. Such as static_pages_seeds.

Mind that this file is called in two places:

  1. When a developer is seeding a database:
    Decidim::System::PopulateHelp.call(organization)
  2. When a system admin creates a new organization:

So, instead of calling it static_pages_seeds and checking out specially the RegisterOrganization calls, I think this should be called CreateDefaultHelpPages.

Related to this, we also should rename RegisterOrganization to CreateOrganization

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: system type: change PRs that implement a change for an existing feature
Projects
Status: 📋 Backlog
Development

Successfully merging a pull request may close this issue.

2 participants