Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to Scan docker Image by providing tar archive directly #20

Open
sufiyanghori opened this issue Jun 25, 2021 · 3 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@sufiyanghori
Copy link

Hi,
When the image scan is executed the SecretScanner runs docker save and then extract the content of the saved tar then perform a scan on it.

It would be great to have a functionality to provide the tar image directly for scanning so that we don't have to use Docker daemon to run docker save first.

@sufiyanghori-apt
Copy link

The idea is to run SecretScanner inside a Docker container where it has no access to Docker daemon from the host.
For now, I have implemented a workaround myself, by using a 3rd party tool to create image archive, and then supplying that archive to SecretScanner.

In order to achieve that, I had to add a functionality in SecretScanner to accept the tar archive as an input.

@DrSahoo
Copy link
Contributor

DrSahoo commented Jul 9, 2021

The idea is to run SecretScanner inside a Docker container where it has no access to Docker daemon from the host.
For now, I have implemented a workaround myself, by using a 3rd party tool to create image archive, and then supplying that archive to SecretScanner.

In order to achieve that, I had to add a functionality in SecretScanner to accept the tar archive as an input.

Thanks for the update. This is a useful feature for SecretScanner. Would you like to raise a pull request for this change?

@sufiyanghori
Copy link
Author

sufiyanghori commented Jul 9, 2021

The idea is to run SecretScanner inside a Docker container where it has no access to Docker daemon from the host.
For now, I have implemented a workaround myself, by using a 3rd party tool to create image archive, and then supplying that archive to SecretScanner.
In order to achieve that, I had to add a functionality in SecretScanner to accept the tar archive as an input.

Thanks for the update. This is a useful feature for SecretScanner. Would you like to raise a pull request for this change?

For sure, I will do a pull request soon :)

@ibreakthecloud ibreakthecloud added the enhancement New feature or request label Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants