Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opened panels should match the state of panels in the panels menu #1924

Open
bmingles opened this issue Apr 5, 2024 · 2 comments · May be fixed by #1925
Open

Opened panels should match the state of panels in the panels menu #1924

bmingles opened this issue Apr 5, 2024 · 2 comments · May be fixed by #1925
Assignees
@bmingles
Labels
enhancement New feature or request web-client-ui
Milestone
Backlog

Comments

@bmingles
Copy link
Contributor

bmingles commented Apr 5, 2024

Panels in the panels menu currently get updated whenever field update events are fired on the connection (connection.subscribeToFieldUpdates in AppMainContainer). These respond to any changes on the server not just the current session. In contrast, panels that are opened only update when commands are issued to the current console session. They do not update if a command is issued from a different session.

It would be preferred if open panels always reflected the same state as the panels in the panels menu.

  1. This avoids a mismatch such that clicking on a panel in the menu results in a different state than a currently opened panel
  2. This opens up some interesting options for other sessions to update panels such as IDE extensions
@bmingles bmingles added enhancement New feature or request triage Issue requires triage labels Apr 5, 2024
@bmingles bmingles self-assigned this Apr 5, 2024
@bmingles bmingles linked a pull request Apr 5, 2024 that will close this issue
Draft
@mattrunyon
Copy link
Collaborator

mattrunyon commented Apr 5, 2024 •
edited

The first point is intentional I believe. There are use cases where people want multiple copies of the same table but might buy filtering it differently in the UI.

Or do you mean if there are server side changes a panel opened from the panel menu doesn't update?

@bmingles
Copy link
Contributor Author

bmingles commented Apr 5, 2024

Correct, opened panels never update based on server side changes that aren't initiated from the current console session. e.g. running command in a different browser tab would not update the opened panel in the current tab, but if you clicked on the same name in the panels menu, it would then update with what was in the other browser tab.

@vbabich vbabich added this to the Backlog milestone Apr 9, 2024
@vbabich vbabich removed the triage Issue requires triage label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmingles bmingles

Labels
enhancement New feature or request web-client-ui
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

feat: Update panels from field change events bmingles/web-client-ui
3 participants
@bmingles @vbabich @mattrunyon