Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deephaven.ui widgets do not appear in Console dropdowns #1884

Open
mofojed opened this issue Mar 20, 2024 · 5 comments · May be fixed by #2013
Open

deephaven.ui widgets do not appear in Console dropdowns #1884

mofojed opened this issue Mar 20, 2024 · 5 comments · May be fixed by #2013
Assignees
@mofojed
Labels
bug Something isn't working
Milestone
June 2024

Comments

@mofojed
Copy link
Member

mofojed commented Mar 20, 2024

Description

When you create deephaven.ui components, they do not appear under the Console table or widget dropdowns. They're only under the Panels menu.

Steps to reproduce

  1. Create a deephaven.ui widget in the console:
from deephaven import ui

foo = ui.text("Bar")
  1. Check the table/figure dropdowns in the Console panel

Expected results
2. foo should appear in a dropdown and be openable

Actual results
2. foo does not appear in either dropdown. It only appears under "Panels"

Additional details and attachments
We should consider having one dropdown for all the objects, with a filter in that dropdown for type? The dropdown is redundant of the Panels menu, get rid of it entirely (for Core)?

Versions
Engine Version: 0.34.0-SNAPSHOT
Web UI Version: 0.69.1
Java Version: 11.0.22
Barrage Version: 0.6.0
Browser Name: Chrome 122
OS Name: Linux
@mofojed mofojed added bug Something isn't working triage Issue requires triage labels Mar 20, 2024
@dsmmcken
Copy link
Contributor

get rid of it entirely (for Core)

consider having one dropdown for all the objects (for enterprise)

I support that.

@vbabich vbabich added this to the April 2024 milestone Mar 26, 2024
@vbabich vbabich removed the triage Issue requires triage label Mar 26, 2024
@mofojed
Copy link
Member Author

mofojed commented Apr 12, 2024

@wusteven815 you should be able to just delete ConsoleMenu, and just pull the "More Actions..." part up into ConsoleStatusBar.

For Enterprise I'll take care of consolidating the dropdown when I convert to use the Core Console Plugin from Enterprise (DH-16756)

@mofojed mofojed assigned mofojed and unassigned wusteven815 Apr 15, 2024
@mofojed
Copy link
Member Author

mofojed commented Apr 17, 2024

Taking this because I'll be refactoring Console/ConsolePlugin with DH-16263 already.

@mattrunyon
Copy link
Collaborator

The console dropdown and panels menu have a slight behavior difference in enterprise at least.

Console dropdown -> reopen over existing panel the console opened (DH-16614 is a bug w/ this behavior)
Panels menu -> open new panel w/ the widget

From the panels menu you can open the same widget multiple times. I think it's fine to combine as the difference is not communicated to users, but just wanted to note it

@mofojed
Copy link
Member Author

mofojed commented Apr 24, 2024

Related to #1962

@mofojed mofojed modified the milestones: April 2024, May 2024 May 13, 2024
@mofojed mofojed linked a pull request May 14, 2024 that will close this issue
Open
@mofojed mofojed modified the milestones: May 2024, June 2024 Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mofojed mofojed

Labels
bug Something isn't working
Projects
None yet
Milestone
June 2024
Development

Successfully merging a pull request may close this issue.

feat: Refactor console objects menu mofojed/web-client-ui
5 participants
@dsmmcken @vbabich @mofojed @mattrunyon @wusteven815