Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown widgets do not persist refresh if they were not edited #1777

Closed
mattrunyon opened this issue Feb 6, 2024 · 0 comments · Fixed by #2019
Closed

Markdown widgets do not persist refresh if they were not edited #1777

mattrunyon opened this issue Feb 6, 2024 · 0 comments · Fixed by #2019
Assignees
@AkshatJawne
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
Backlog

Comments

@mattrunyon
Copy link
Collaborator

mattrunyon commented Feb 6, 2024 •
edited

Description

Markdown widgets only seem to get saved in the layout if they are edited. If they are not, their space is replaced w/ blank space in the layout on page reload

Steps to reproduce

  1. Create a markdown widget from the controls panel.
  2. Refresh the page

Expected results

  1. Markdown panel reloads where it was

Actual results

  1. Markdown panel space is blank and no panel is loaded (bottom right quadrant in this screenshot had a markdown panel before reload)
    image

Versions

Engine Version: 0.33.0-SNAPSHOT
Web UI Version: 0.62.0
Java Version: 11.0.21
Barrage Version: 0.6.0
Browser Name: Chrome 121
OS Name: Linux
@mattrunyon mattrunyon added bug Something isn't working triage Issue requires triage labels Feb 6, 2024
@vbabich vbabich added this to the Backlog milestone Feb 13, 2024
@vbabich vbabich added good first issue Good for newcomers and removed triage Issue requires triage labels Feb 13, 2024
@mofojed mofojed modified the milestone: Backlog May 13, 2024
@AkshatJawne AkshatJawne mentioned this issue May 15, 2024
Merged
AkshatJawne added a commit that referenced this issue May 24, 2024
@AkshatJawne
fix: Unedited markdown widgets not persisting (#2019)
c17f136 
Resolves #1777

Changes Implemented:
- Added checks, modified hydration logic, and added new conditions for what is considered a closed markdown, to ensure proper persistence of markdown widget
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AkshatJawne AkshatJawne

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

fix: Unedited markdown widgets not persisting AkshatJawne/web-client-ui
4 participants
@vbabich @mofojed @mattrunyon @AkshatJawne