Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated shortid package with nanoid #1922

Closed
mofojed opened this issue Apr 5, 2024 · 1 comment · Fixed by #2025
Closed

Replace deprecated shortid package with nanoid #1922

mofojed opened this issue Apr 5, 2024 · 1 comment · Fixed by #2025
Assignees
@AkshatJawne
Labels
bug Something isn't working
Milestone
May 2024

Comments

@mofojed
Copy link
Member

mofojed commented Apr 5, 2024

shortid is deprecated. Should replace with nanoid
@mofojed mofojed added bug Something isn't working triage Issue requires triage labels Apr 5, 2024
@mofojed mofojed changed the title Replace shortid package Replace deprecated shortid package with nanoid Apr 5, 2024
@dsmmcken
Copy link
Contributor

dsmmcken commented Apr 5, 2024

what about useId? https://react.dev/reference/react/useId

@vbabich vbabich added this to the April 2024 milestone Apr 9, 2024
@vbabich vbabich removed the triage Issue requires triage label Apr 9, 2024
@mofojed mofojed mentioned this issue Apr 16, 2024
Merged
@mofojed mofojed modified the milestones: April 2024, May 2024 May 13, 2024
@AkshatJawne AkshatJawne self-assigned this May 17, 2024
@AkshatJawne AkshatJawne mentioned this issue May 17, 2024
Merged
AkshatJawne added a commit that referenced this issue May 23, 2024
@AkshatJawne
fix: Replace shortid package with nanoid package (#2025)
30d9d3c 
Resolves #1922

Changes Implemented:
- Replaced shortid with nanoid, given that shortid is deprecated (Reran
all tests to ensure that functionality upholds)

Info on Nanoid: https://github.com/ai/nanoid/blob/main/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AkshatJawne AkshatJawne

Labels
bug Something isn't working
Projects
None yet
Milestone
May 2024
Development

Successfully merging a pull request may close this issue.

fix: Replace shortid package with nanoid package AkshatJawne/web-client-ui
4 participants
@dsmmcken @vbabich @mofojed @AkshatJawne