Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unique names for all resources #88

Open
RothAndrew opened this issue Mar 2, 2023 · 1 comment
Open

Use unique names for all resources #88

RothAndrew opened this issue Mar 2, 2023 · 1 comment

Comments

@RothAndrew
Copy link
Member

If 2 people run terraform apply using the same variables, name conflicts will occur. For example, If 2 people use bastion_name = "my-bastion" in the same aws account, IAM policies such as "my-bastion-s3-readonly" (and a bunch of others) will have name conflicts.

This is likely to happen as we introduce automated testing. I'm surprised it hasn't already just from people reusing the same example tfvars files in the same account.

We could append some UUID to every resource name/id. We do this for certain things already by applying what looks to be a datetime stamp, but we don't currently do that everywhere.

@RothAndrew
Copy link
Member Author

Clarification: We should make the modules take care of adding uniqueness. Currently in #90 the example is defining unique names and passing them to the modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant