Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --retries on deploy operations #531

Closed
Racer159 opened this issue Mar 28, 2024 · 1 comment · Fixed by #532
Closed

Support --retries on deploy operations #531

Racer159 opened this issue Mar 28, 2024 · 1 comment · Fixed by #532
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Racer159
Copy link
Contributor

Is your feature request related to a problem? Please describe

As Ezra I want to be able to specify Helm and image retries so that I can have a more robust deploy process.

Describe the solution you'd like

  • Given I have a UDS bundle with large images
  • When I run uds deploy <bundle> --retries <x>
  • Then uds-cli passes that along to Zarf's package options
  • And When an image push error or Helm error occurs
  • Then the deployment respects that value

Describe alternatives you've considered

This is currently a feature of Zarf, uds-cli could implement their own version but the easiest path for now is to reuse the same logic.

Additional context

This should be relatively simple to wire in, requiring a new command flag:

// deploy cmd flags

wired to package options (which has retries in it):
https://github.com/defenseunicorns/uds-cli/blob/main/src/pkg/bundle/deploy.go#L123

@Racer159 Racer159 added enhancement New feature or request good first issue Good for newcomers labels Mar 28, 2024
@eddiezane
Copy link
Member

ref: defenseunicorns/zarf#2345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants