Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: hotfix the spoof containing a dash in the input and add a publish step #81

Merged
merged 5 commits into from Mar 25, 2024
Merged

chore: hotfix the spoof containing a dash in the input and add a publish step #81

merged 5 commits into from Mar 25, 2024

Conversation

Racer159
Copy link
Contributor

Fix this again...

@zachariahmiller zachariahmiller changed the title Hotfix spoof2 chore: hotfix spoof2 Mar 22, 2024
@Racer159 Racer159 changed the title chore: hotfix spoof2 chore: hotfix the spoof containing a dash in the input Mar 22, 2024
zachariahmiller
zachariahmiller requested changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@zachariahmiller zachariahmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets try adding "tests" to the tasks so the repo self-validates the changes. Will make it easier to iterate quickly with high confidence

@Racer159 Racer159 requested a review from a team as a code owner March 22, 2024 17:49
@Racer159 Racer159 changed the title chore: hotfix the spoof containing a dash in the input chore: hotfix the spoof containing a dash in the input and add a publish step Mar 22, 2024
zachariahmiller
zachariahmiller approved these changes Mar 24, 2024
View reviewed changes
Copy link
Contributor

@zachariahmiller zachariahmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Racer159 Racer159 merged commit f9c7aac into main Mar 25, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachariahmiller zachariahmiller zachariahmiller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Racer159 @zachariahmiller