fix: loki bucket configuration service_account and namespace #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin-o12
approved these changes
Apr 5, 2024
mjnagel
pushed a commit
that referenced
this pull request
Apr 12, 2024
🤖 I have created a release *beep* *boop* --- ## [0.19.0](v0.18.0...v0.19.0) (2024-04-12) ### Features * add nightly testing eks ([#250](#250)) ([543b09d](543b09d)) ### Bug Fixes * drop path normalization to MERGE_SLASHES to allow apps to handle encoded slashes ([#330](#330)) ([26e965f](26e965f)) * loki bucket configuration service_account and namespace ([#332](#332)) ([9518634](9518634)) ### Miscellaneous * **deps:** update grafana ([#257](#257)) ([c98e566](c98e566)) * **deps:** update metrics-server ([#298](#298)) ([691fd87](691fd87)) * **deps:** update pepr ([#324](#324)) ([2ef0f96](2ef0f96)) * **deps:** update pepr to v0.28.7 ([#321](#321)) ([e7206bb](e7206bb)) * **deps:** update promtail ([#74](#74)) ([6a112b5](6a112b5)) * **deps:** update zarf to v0.32.6 ([#282](#282)) ([443426d](443426d)) * **deps:** update zarf to v0.33.0 ([#325](#325)) ([f2a2a66](f2a2a66)) * update codeowners ([#338](#338)) ([c419574](c419574)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The loki service_account and namespace for the eks nightly testing match with what DUBBD deployed not uds-core. Updating those values to match the resources in core.
Related Issue
Fixes #331
Type of change
Checklist before merging