Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable sso for neuvector #351

Merged
merged 7 commits into from
Apr 18, 2024
Merged

feat: enable sso for neuvector #351

merged 7 commits into from
Apr 18, 2024

Conversation

rjferguson21
Copy link
Contributor

@rjferguson21 rjferguson21 commented Apr 17, 2024

Description

Adds Keycloak client creation and SSO configuration for Neuvector.

Related Issue

Fixes #91

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@rjferguson21 rjferguson21 requested a review from a team April 17, 2024 18:15
@rjferguson21
Copy link
Contributor Author

@mjnagel FYI I tested this trying to use the internal address for keycloak and Neuvector complains that the issuer is not consistent between the configured issuer and the issuer from the .well-known endpoint.

mjnagel
mjnagel previously approved these changes Apr 18, 2024
Copy link
Contributor

@mjnagel mjnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - noting that I opened #354 as a follow on/more generic way to approach the secret checksum thing.

Co-authored-by: Micah Nagel <micah.nagel@defenseunicorns.com>
@rjferguson21 rjferguson21 merged commit 597353e into main Apr 18, 2024
9 checks passed
@rjferguson21 rjferguson21 deleted the add-neuvector-sso branch April 18, 2024 21:22
mjnagel pushed a commit that referenced this pull request Apr 20, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.20.0](v0.19.0...v0.20.0)
(2024-04-20)


### Features

* add keycloak sso realm values
([#352](#352))
([74436ea](74436ea))
* add saml and attribute/mapper support for keycloak in uds pepr
operator
([#328](#328))
([c53d4ee](c53d4ee))
* enable sso for neuvector
([#351](#351))
([597353e](597353e))
* keycloak PVC customization
([#341](#341))
([f8eae2a](f8eae2a))


### Bug Fixes

* add nightly uds-bundle.yaml to release-please extras for updates
([#346](#346))
([d1b3071](d1b3071))


### Miscellaneous

* **deps:** update grafana
([#339](#339))
([52e6c1b](52e6c1b))
* **deps:** update neuvector
([#333](#333))
([010e287](010e287))
* **deps:** update pepr
([#340](#340))
([e71ba4a](e71ba4a))
* **deps:** update prometheus-stack
([#301](#301))
([143eca3](143eca3))
* **deps:** update to keycloak 24
([#336](#336))
([1153ba0](1153ba0))
* **deps:** update uds-identity-config to 0.4.1
([#355](#355))
([8485931](8485931))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup SSO for NeuVector, disable basic auth
3 participants