Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor removeCopiesFromComponents to be a filter #2337

Closed
lucasrod16 opened this issue Feb 27, 2024 · 0 comments · Fixed by #2474
Closed

refactor removeCopiesFromComponents to be a filter #2337

lucasrod16 opened this issue Feb 27, 2024 · 0 comments · Fixed by #2474
Labels
tech-debt 💳 Debt that the team has charged and needs to repay

Comments

@lucasrod16
Copy link
Member

lucasrod16 commented Feb 27, 2024 •
edited

Describe what should be investigated or refactored

refactor removeCopiesFromComponents to be a filter

Links to any relevant code

zarf/src/pkg/packager/creator/differential.go

Line 68 in f3efb76

func removeCopiesFromComponents(components []types.ZarfComponent, loadedDiffData *types.DifferentialData) (diffComponents []types.ZarfComponent, err error) {

Additional context

#2223 (comment)

depends on #2321 being merged

cc: @Noxsios
@lucasrod16 lucasrod16 added the tech-debt 💳 Debt that the team has charged and needs to repay label Feb 27, 2024
@lucasrod16 lucasrod16 changed the title refactor removeCopiesFromComponents to be a filter refactor removeCopiesFromComponents to be a filter Feb 27, 2024
@lucasrod16 lucasrod16 mentioned this issue Feb 27, 2024
Merged
5 tasks
This was referenced May 3, 2024
Merged
Merged
AustinAbro321 added a commit that referenced this issue May 6, 2024
@phillebaba @Noxsios @AustinAbro321
test: add tests for remove copies from components to enable refactori…
cfe8f19 
…ng (#2473)

## Description

This change adds tests for remove copies from components to enable
refactoring in the future.

## Related Issue

Relates to #2337

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow)
followed

Co-authored-by: razzle <razzle@defenseunicorns.com>
Co-authored-by: Austin Abro <37223396+AustinAbro321@users.noreply.github.com>
Noxsios added a commit that referenced this issue May 7, 2024
@phillebaba @Noxsios
refactor: remove copies from components to a filter (#2474)
bf69112 
## Description

This change refactors remove copies from components to a filter.

## Related Issue

Depends on: #2473
Fixes #2337 

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow)
followed

---------

Co-authored-by: razzle <razzle@defenseunicorns.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech-debt 💳 Debt that the team has charged and needs to repay
Projects
Zarf
Status: Done
Zarf Project Board
Status: New
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: remove copies from components to a filter phillebaba/zarf
1 participant
@lucasrod16