Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add missing vendored tool version commands #2232

Merged
merged 2 commits into from Mar 4, 2024
Merged

feat: add missing vendored tool version commands #2232

merged 2 commits into from Mar 4, 2024

Conversation

eddiezane
Copy link
Member

Description

This PR adds missing version commands to the bundled tools.

Related Issue

Fixes #2142

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@netlify Netlify
Copy link

netlify bot commented Jan 18, 2024 •
edited

✅ Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit b7ddc83
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/65e61c2658ff7e000815a7c8
😎 Deploy Preview https://deploy-preview-2232--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Racer159
Racer159 requested changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you'll need to run make docs-and-schema to update the CLI docs but otherwise the code looks good!

@Noxsios
Copy link
Contributor

Noxsios commented Jan 21, 2024 •
edited

Will need ldflags changes on .goreleaser.yaml, and environment variable updates to .github/workflows/release.yml

@eddiezane eddiezane requested a review from a team as a code owner January 22, 2024 18:42
Racer159
Racer159 requested changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more changes - also while the commit is unsigned - its unverified which may cause issues (partially verified commits can be merged but generally our repo settings will reject unverified ones)

.goreleaser.yaml Outdated Show resolved Hide resolved
src/cmd/tools/archiver.go Outdated Show resolved Hide resolved
@Racer159 Racer159 changed the title Add missing tool version commands featr: add missing vendored tool version commands Jan 23, 2024
@Racer159 Racer159 changed the title featr: add missing vendored tool version commands feat: add missing vendored tool version commands Jan 23, 2024
@UncleGedd UncleGedd mentioned this pull request Jan 26, 2024
Closed
@eddiezane eddiezane force-pushed the ez/add-tool-versions branch 2 times, most recently from 6fd8bd6 to 8a4aca8 Compare March 2, 2024 00:24
@eddiezane
Copy link
Member Author

@Racer159 resigned the commit with a GPG key. Good for another check and 🚢

Racer159
Racer159 requested changes Mar 4, 2024
View reviewed changes
src/cmd/tools/common.go Outdated Show resolved Hide resolved
@eddiezane
Add missing tool version commands
1ea4782 
Signed-off-by: Eddie Zaneski <eddiezane@gmail.com>
@eddiezane eddiezane requested a review from Racer159 March 4, 2024 16:20
Racer159
Racer159 approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Racer159 Racer159 merged commit b807e15 into main Mar 4, 2024
29 checks passed
@Racer159 Racer159 deleted the ez/add-tool-versions branch March 4, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Racer159 Racer159 Racer159 approved these changes

@jeff-mccoy jeff-mccoy Awaiting requested review from jeff-mccoy

@Noxsios Noxsios Awaiting requested review from Noxsios

@lucasrod16 lucasrod16 Awaiting requested review from lucasrod16

@Madeline-UX Madeline-UX Awaiting requested review from Madeline-UX

@AustinAbro321 AustinAbro321 Awaiting requested review from AustinAbro321

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Zarf Project Board
Status: Approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export version with zarf tools
3 participants
@eddiezane @Noxsios @Racer159