Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor and purify the OCI library within Zarf. #2235

Merged
merged 144 commits into from Mar 4, 2024
Merged

Conversation

AustinAbro321
Copy link
Contributor

@AustinAbro321 AustinAbro321 commented Jan 19, 2024

Description

Move OCI lib out, so it can be more easily used with other projects and contributed to by multiple teams.

Fixes: #2252 #2288

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Copy link

netlify bot commented Jan 19, 2024

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 8613b74
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/65e60b9a58ff7e000855c111

@Noxsios Noxsios changed the title move oci lib out refactor: move OCI lib to pkg repository Jan 19, 2024
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to these changes we should also move /src/utils/helpers as well since that would be easy and is the core of a lot of our lib code.

src/pkg/oci/common.go Show resolved Hide resolved
src/pkg/oci/common.go Outdated Show resolved Hide resolved
src/pkg/oci/copier.go Show resolved Hide resolved
src/pkg/oci/manifest.go Show resolved Hide resolved
src/pkg/oci/pull.go Show resolved Hide resolved
src/pkg/oci/pull.go Show resolved Hide resolved
src/pkg/oci/pull.go Show resolved Hide resolved
src/pkg/oci/push.go Show resolved Hide resolved
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussing more with @Noxsios it would likely be better to purify this functionality within Zarf (i.e. do the refactoring in Zarf for the OCI library to not rely on Zarf first, then move it out to keep things cleaner)

@Racer159 Racer159 changed the title refactor: move OCI lib to pkg repository chore: refactor and purify the OCI library within Zarf. Jan 23, 2024
lucasrod16
lucasrod16 previously approved these changes Feb 29, 2024
Copy link
Member

@lucasrod16 lucasrod16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

src/pkg/message/handler.go Outdated Show resolved Hide resolved
src/pkg/zoci/pull.go Outdated Show resolved Hide resolved
Racer159
Racer159 previously approved these changes Mar 4, 2024
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Noxsios
Noxsios previously approved these changes Mar 4, 2024
@AustinAbro321 AustinAbro321 dismissed stale reviews from Noxsios and Racer159 via ea06cdd March 4, 2024 17:50
@Racer159 Racer159 merged commit bc7987c into main Mar 4, 2024
23 checks passed
@Racer159 Racer159 deleted the move-oci-lib-out branch March 4, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Approved
Development

Successfully merging this pull request may close these issues.

Move helpers to common library
4 participants