Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added OCI Image Index mediaType #2352

Merged
merged 2 commits into from Mar 4, 2024

Conversation

mdaizcorbe
Copy link
Contributor

Description

Added the OCI Image Index's mediaType for completeness sake per the OCI spec and to work around a known Sonatype Nexus Repository bug.

Related Issue

Fixes #2351

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Copy link

netlify bot commented Mar 4, 2024

Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit 13825c7
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/65e60433d82c5b0008f5c50e
😎 Deploy Preview https://deploy-preview-2352--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Noxsios
Copy link
Contributor

Noxsios commented Mar 4, 2024

@mdaizcorbe Thanks for the contribution!

@AustinAbro321 also noticed this in his current OCI library refactor work: #2235.

If you have the time, are you able to verify this fixes Nexus?

@Noxsios Noxsios changed the title Added OCI Image Index mediaType fix: added OCI Image Index mediaType Mar 4, 2024
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Racer159 Racer159 merged commit ac703d5 into defenseunicorns:main Mar 4, 2024
23 checks passed
@mdaizcorbe
Copy link
Contributor Author

@mdaizcorbe Thanks for the contribution!

@AustinAbro321 also noticed this in his current OCI library refactor work: #2235.

If you have the time, are you able to verify this fixes Nexus?

Yes, I reproduced the issue on a Nexus Repo container instance running locally using the current release of Zarf CLI. Then rebuilt the Zarf CLI with the one line change and all OCI artifacts persisted after several manual runs of the Nexus Repo cleanup task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Approved
Development

Successfully merging this pull request may close these issues.

OCI Image Index for Zarf packages doesn't include the mediaType attribute
4 participants