Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): change ECR image to docker.io image #2353

Merged
merged 1 commit into from Mar 4, 2024

Conversation

AustinAbro321
Copy link
Contributor

Description

This fixes a test flake we see where we get TOOMANYREQUESTS on ECR pulls during CI runs on occasion. Example: https://github.com/defenseunicorns/zarf/actions/runs/8135568196/job/22230376242?pr=2292

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Copy link

netlify bot commented Mar 4, 2024

Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit c02dabd
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/65e5f61830e82100089db6a1
😎 Deploy Preview https://deploy-preview-2353--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Noxsios Noxsios changed the title change ecr image to docker.io image chore(ci): change ECR image to docker.io image Mar 4, 2024
@Noxsios Noxsios changed the title chore(ci): change ECR image to docker.io image fix(ci): change ECR image to docker.io image Mar 4, 2024
Copy link
Contributor

@Racer159 Racer159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Racer159 Racer159 merged commit 169da50 into main Mar 4, 2024
25 checks passed
@Racer159 Racer159 deleted the remove-ecr-image-from-argo-chart branch March 4, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Approved
Development

Successfully merging this pull request may close these issues.

None yet

2 participants