Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update injector away from rouille to axum #2457

Merged
merged 2 commits into from May 15, 2024
Merged

feat: update injector away from rouille to axum #2457

merged 2 commits into from May 15, 2024

Conversation

schristoff
Copy link
Contributor

@schristoff schristoff commented Apr 24, 2024 •
edited by schristoff-du

Fixes #592

@netlify Netlify
Copy link

netlify bot commented Apr 24, 2024 •
edited

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit fd6f647
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/664528cb0b02ea00088584df

@schristoff-du schristoff-du changed the title (bug): Update injector away from rouille to axum bug: Update injector away from rouille to axum May 10, 2024
@schristoff-du schristoff-du changed the title bug: Update injector away from rouille to axum feat: Update injector away from rouille to axum May 10, 2024
@schristoff-du schristoff-du changed the title feat: Update injector away from rouille to axum feat: update injector away from rouille to axum May 10, 2024
@schristoff-du schristoff-du marked this pull request as ready for review May 10, 2024 23:30
@schristoff-du schristoff-du requested a review from a team as a code owner May 10, 2024 23:30
eddiezane
eddiezane requested changes May 10, 2024
View reviewed changes
Copy link
Member

@eddiezane eddiezane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job on this!

packages/zarf-registry/armregistry-zarf Outdated Show resolved Hide resolved
src/injector/README.md Outdated Show resolved Hide resolved
src/injector/src/main.rs Outdated Show resolved Hide resolved
src/injector/src/main.rs Outdated Show resolved Hide resolved
src/injector/src/main.rs Outdated Show resolved Hide resolved
src/injector/src/main.rs Outdated Show resolved Hide resolved
lucasrod16
lucasrod16 reviewed May 13, 2024
View reviewed changes
Copy link
Member

@lucasrod16 lucasrod16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working on my machine 🎉 nice work!

Could we go over the Rust changes in one of our syncs this week? I'm not too familiar with Rust and it would help me understand them better.

src/injector/README.md Outdated Show resolved Hide resolved
src/injector/README.md Show resolved Hide resolved
eddiezane
eddiezane reviewed May 14, 2024
View reviewed changes
Copy link
Member

@eddiezane eddiezane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a few extra comments

.github/actions/k3d/action.yaml Show resolved Hide resolved
.github/workflows/build-rust-injector.yml Outdated Show resolved Hide resolved
src/injector/src/main.rs Show resolved Hide resolved
lucasrod16
lucasrod16 previously approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@lucasrod16 lucasrod16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

eddiezane
eddiezane previously approved these changes May 15, 2024
View reviewed changes
@schristoff
bug: fix rust injector
4750146 
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
@schristoff schristoff dismissed stale reviews from lucasrod16 and eddiezane via 4750146 May 15, 2024 21:25
@schristoff
clean up rebase
fd6f647 
Signed-off-by: schristoff <28318173+schristoff@users.noreply.github.com>
@schristoff-du schristoff-du merged commit 75c9826 into defenseunicorns:main May 15, 2024
30 checks passed
@lucasrod16 lucasrod16 mentioned this pull request May 16, 2024
Merged
2 tasks
AustinAbro321 pushed a commit that referenced this pull request May 16, 2024
@lucasrod16
chore: remove rouille CVE from grype ignore (#2515)
f6fe020 
## Description
#2457 removed rouille as a dependency

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/.github/CONTRIBUTING.md#developer-workflow)
followed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schristoff-du schristoff-du schristoff-du left review comments

@lucasrod16 lucasrod16 lucasrod16 approved these changes

@eddiezane eddiezane eddiezane left review comments

@dgershman dgershman Awaiting requested review from dgershman dgershman is a code owner

@jeff-mccoy jeff-mccoy Awaiting requested review from jeff-mccoy

@austenbryan austenbryan Awaiting requested review from austenbryan

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Zarf Project Board
Status: New
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zarf-Seed-Registry Installation Fails on Init with Deployment is not ready: zarf/zarf-docker-registry error
4 participants
@schristoff @eddiezane @lucasrod16 @schristoff-du