Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add key management provider and cosign docs #58

Merged
merged 20 commits into from
May 18, 2024
Merged

docs: add key management provider and cosign docs #58

merged 20 commits into from
May 18, 2024

Conversation

akashsinghal
Copy link
Collaborator

@akashsinghal akashsinghal commented Mar 21, 2024 •
edited

This PR builds on #69 and MUST be merged after.

Adds new documentation for Key Management Providers:

  • adds new Key Management Provider resource docs under CRDs section
  • general docs clean up and title renaming
  • Moves some docs around
  • adds error troubleshooting documentation

Adds new documentation for Cosign verifier

  • adds new demo and walkthrough
  • adds section on trust policies

fixes #47

@netlify Netlify
Copy link

netlify bot commented Mar 21, 2024 •
edited

✅ Deploy Preview for ratify-dev ready!

Name Link
🔨 Latest commit 50ae74f
🔍 Latest deploy log https://app.netlify.com/sites/ratify-dev/deploys/66467c3d4d38270008551d04
😎 Deploy Preview https://deploy-preview-58--ratify-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@binbin-li binbin-li mentioned this pull request May 7, 2024
Merged
@akashsinghal akashsinghal changed the title docs: add key management provider docs: add key management provider and cosign docs May 8, 2024
susanshi
susanshi reviewed May 10, 2024
View reviewed changes
Copy link
Collaborator

@susanshi susanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding the cosign verifier doc! left some suggestions. Is PR is getting a bit large, is it possible to break this down to smaller PRs?

docs/plugins/Verifier/cosign.md Outdated Show resolved Hide resolved
docs/plugins/Verifier/cosign.md Outdated Show resolved Hide resolved
docs/plugins/Verifier/cosign.md Outdated Show resolved Hide resolved
@akashsinghal akashsinghal marked this pull request as ready for review May 15, 2024 21:55
susanshi
susanshi previously approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@susanshi susanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks!

susanshi
susanshi approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@susanshi susanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the doc updates. LGTM.

binbin-li
binbin-li approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@binbin-li binbin-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left minor comments, lgtm overall, thanks for adding the doc!

docs/plugins/verifier/cosign.md Show resolved Hide resolved
docs/plugins/verifier/cosign.md Show resolved Hide resolved
@binbin-li binbin-li merged commit 3a8a42c into ratify-project:main May 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binbin-li binbin-li binbin-li approved these changes

@susanshi susanshi susanshi approved these changes

@luisdlp luisdlp Awaiting requested review from luisdlp luisdlp is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a walkthrough to setup cosign verifier
3 participants
@akashsinghal @binbin-li @susanshi