Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add how-to for Cosign signatures and AKV #68

Merged
merged 16 commits into from
May 23, 2024

Conversation

yizha1
Copy link
Contributor

@yizha1 yizha1 commented May 9, 2024

fixes #65
fixes #72

Note: Please merge this PR after v1.2.0 is released

Signed-off-by: Yi Zha yizha1@microsoft.com

Signed-off-by: Yi Zha <yizha1@microsoft.com>
Copy link

netlify bot commented May 9, 2024

Deploy Preview for ratify-dev ready!

Name Link
🔨 Latest commit c816363
🔍 Latest deploy log https://app.netlify.com/sites/ratify-dev/deploys/664e9610ab4bf700098eccd2
😎 Deploy Preview https://deploy-preview-68--ratify-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yizha1
Copy link
Contributor Author

yizha1 commented May 9, 2024

@FeynmanZhou Please comment how to add this document for version v1.2.0

yizha1 added 2 commits May 9, 2024 22:20
Signed-off-by: Yi Zha <yizha1@microsoft.com>
Signed-off-by: Yi Zha <yizha1@microsoft.com>
@FeynmanZhou
Copy link
Collaborator

FeynmanZhou commented May 10, 2024

@FeynmanZhou Please comment how to add this document for version v1.2.0

@yizha1
This PR change is in the right location.

We need to create another PR to replicate the docs folder to https://github.com/deislabs/ratify-web/tree/main/versioned_docs and name it version-1.2 as a previous version after all v1.2 related docs are finalized.

@susanshi
Copy link
Collaborator

susanshi commented May 14, 2024

Thanks for authoring this workthrough Yi. We discussed this PR at the PR review meeting today. We suggest moving/merging this PR into https://ratify.dev/docs/quickstarts/ratify-on-azure/ doc. Ideally, we should have a consistent format in Ratify walkthroughs, we are hoping Ratify on AWS vs Ratify on Azure can have consistent titles and sections, it then will be easy for the customer to compare.

Copy link
Collaborator

@susanshi susanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments, thanks!

docs/quickstarts/cosign-akv-azure.md Outdated Show resolved Hide resolved
docs/quickstarts/cosign-akv-azure.md Outdated Show resolved Hide resolved
docs/quickstarts/cosign-akv-azure.md Outdated Show resolved Hide resolved
Signed-off-by: Yi Zha <yizha1@microsoft.com>
Signed-off-by: Yi Zha <yizha1@microsoft.com>
Signed-off-by: Yi Zha <yizha1@microsoft.com>
Signed-off-by: Yi Zha <yizha1@microsoft.com>
Signed-off-by: Yi Zha <yizha1@microsoft.com>
@yizha1
Copy link
Contributor Author

yizha1 commented May 19, 2024

@akashsinghal @susanshi Please review this doc again. The cosign parts were merged to Ratify on Azure, resulting this doc a bit longer and needing to consider which is common part for Cosign and Notation.

@FeynmanZhou Would you mind updating the e2e picture to reflect that cosign can also be used?

Signed-off-by: Yi Zha <yizha1@microsoft.com>
Signed-off-by: Yi Zha <yizha1@microsoft.com>
Copy link
Collaborator

@susanshi susanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the updates Yi. Left some comments.

docs/quickstarts/ratify-on-azure.md Show resolved Hide resolved
docs/quickstarts/ratify-on-azure.md Show resolved Hide resolved
docs/quickstarts/ratify-on-azure.md Show resolved Hide resolved
docs/quickstarts/ratify-on-azure.md Show resolved Hide resolved
docs/quickstarts/ratify-on-azure.md Show resolved Hide resolved
Signed-off-by: Yi Zha <yizha1@microsoft.com>
Signed-off-by: Yi Zha <yizha1@microsoft.com>
susanshi
susanshi previously approved these changes May 22, 2024
Copy link
Collaborator

@susanshi susanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates Yi! LGTM.

akashsinghal
akashsinghal previously approved these changes May 22, 2024
Copy link
Collaborator

@akashsinghal akashsinghal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Yi!

@yizha1 yizha1 dismissed stale reviews from akashsinghal and susanshi via 7745f88 May 23, 2024 01:00
Signed-off-by: Yi Zha <yizha1@microsoft.com>
@yizha1 yizha1 requested a review from susanshi May 23, 2024 01:05
Copy link
Collaborator

@susanshi susanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@susanshi susanshi merged commit 91c6899 into ratify-project:main May 23, 2024
4 checks passed
@yizha1 yizha1 deleted the add_cosign_akv branch May 23, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants