-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add how-to for Cosign signatures and AKV #68
Conversation
Signed-off-by: Yi Zha <yizha1@microsoft.com>
✅ Deploy Preview for ratify-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@FeynmanZhou Please comment how to add this document for version v1.2.0 |
Signed-off-by: Yi Zha <yizha1@microsoft.com>
Signed-off-by: Yi Zha <yizha1@microsoft.com>
@yizha1 We need to create another PR to replicate the docs folder to https://github.com/deislabs/ratify-web/tree/main/versioned_docs and name it |
Thanks for authoring this workthrough Yi. We discussed this PR at the PR review meeting today. We suggest moving/merging this PR into https://ratify.dev/docs/quickstarts/ratify-on-azure/ doc. Ideally, we should have a consistent format in Ratify walkthroughs, we are hoping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments, thanks!
Signed-off-by: Yi Zha <yizha1@microsoft.com>
Signed-off-by: Yi Zha <yizha1@microsoft.com>
Signed-off-by: Yi Zha <yizha1@microsoft.com>
Signed-off-by: Yi Zha <yizha1@microsoft.com>
Signed-off-by: Yi Zha <yizha1@microsoft.com>
@akashsinghal @susanshi Please review this doc again. The cosign parts were merged to Ratify on Azure, resulting this doc a bit longer and needing to consider which is common part for Cosign and Notation. @FeynmanZhou Would you mind updating the e2e picture to reflect that cosign can also be used? |
Signed-off-by: Yi Zha <yizha1@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the updates Yi. Left some comments.
Signed-off-by: Yi Zha <yizha1@microsoft.com>
Signed-off-by: Yi Zha <yizha1@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates Yi! LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks Yi!
Signed-off-by: Yi Zha <yizha1@microsoft.com>
Signed-off-by: Yi Zha <yizha1@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
fixes #65
fixes #72
Note: Please merge this PR after v1.2.0 is released
Signed-off-by: Yi Zha yizha1@microsoft.com