Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release 1.2 rc1 helm file updates #1482

Closed
wants to merge 2 commits into from

Conversation

susanshi
Copy link
Collaborator

Description

What this PR does / why we need it:

release 1.2 rc1 helm file updates

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

binbin-li
binbin-li previously approved these changes May 16, 2024
Copy link
Collaborator

@binbin-li binbin-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

high-availability.helmfile.yaml Show resolved Hide resolved
@akashsinghal
Copy link
Collaborator

@susanshi @binbin-li are we sure we want this PR to merge for RC? Our main quickstart points to these files. Do we want users using a non stable version?

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.15%. Comparing base (1bd347c) to head (9f675ac).
Report is 36 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1482      +/-   ##
==========================================
+ Coverage   66.76%   68.15%   +1.38%     
==========================================
  Files         116      119       +3     
  Lines        6030     6139     +109     
==========================================
+ Hits         4026     4184     +158     
+ Misses       1620     1561      -59     
- Partials      384      394      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@susanshi susanshi changed the base branch from release-1.2 to dev May 21, 2024 00:05
@susanshi susanshi dismissed binbin-li’s stale review May 21, 2024 00:05

The base branch was changed.

@susanshi
Copy link
Collaborator Author

For the actual 1.2 release, we need to update the helmfile in the dev branch.

@susanshi susanshi closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants