Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dekorate only allows providing the image info via suppliers, not configurators #1147

Open
Sgitario opened this issue Feb 2, 2023 · 0 comments

Comments

@Sgitario
Copy link
Collaborator

Sgitario commented Feb 2, 2023

We can't provide a custom image info configuration using the Configurator class:

public class ApplyImageInfoConfigurator extends Configurator<ImageConfigurationFluent<?>> {

    @Override
    public void visit(ImageConfigurationFluent<?> image) {
       // ...
    }
}

But it works when using ConfigurationSupplier:

public class ApplyImageInfoConfigurationSupplier extends ConfigurationSupplier<ImageConfiguration> {

    public ApplyImageInfoConfigurationSupplier(ContainerImageInfoBuildItem image, String defaultRegistry) {
        super(create(image, defaultRegistry));
    }

    private static ImageConfigurationBuilder create(ContainerImageInfoBuildItem image, String defaultRegistry) {
        ImageConfigurationBuilder builder = new ImageConfigurationBuilder();
        // ..
        return builder;
    }

    @Override
    public boolean isExplicit() {
        return true;
    }
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant