fix: invalid warnings when running the Dekorate session #997
Conversation
There are some system properties that are not directly mapped using generators like `dekorate.build` or `dekorate.push`. These properties will either enable some special handling, functionality and/or include some other properties. The problem is that at the moment, the session is checking whether these properties are properly mapped and if not, it will trace a warning. Therefore, as these properties are programmatically used and there are many more like `dekorate.input.dir`, `dekorate.output.dir`, `dekorate.image-pull-secrets`, `dekorate.properties.profile`, `dekorate.verbose`, `dekorate.test.xxx`, ... and maybe more coming in the future, I think the best way is to not trace this warning ever. The alternative is to maintain a list with all the above values, however I don't really like this approach as this list will be likely became out-date when adding a new unmapped property. Fix dekorateio#995
|
Kudos, SonarCloud Quality Gate passed!
|
Before, it was raising exceptions when a configuration was not using a generator, not by a warning trace. I don't totally agree with you about this is something we should tell users. |
Indeed, still no error was thrown when |
There are some system properties that are not directly mapped using generators like
dekorate.buildordekorate.push. These properties will either enable some special handling, functionality and/or include some other properties.The problem is that at the moment, the session is checking whether these properties are properly mapped and if not, it will trace a warning.
Therefore, as these properties are programmatically used and there are many more like
dekorate.input.dir,dekorate.output.dir,dekorate.image-pull-secrets,dekorate.properties.profile,dekorate.verbose,dekorate.test.xxx, ... and maybe more coming in the future, I think the best way is to not trace this warning ever.The alternative is to maintain a list with all the above values, however I don't really like this approach as this list will be likely became out-date when adding a new unmapped property.
Fix #995