Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection validation / disposal is not working #70

Open
GabrielLomba opened this issue Feb 26, 2024 · 0 comments
Open

Connection validation / disposal is not working #70

GabrielLomba opened this issue Feb 26, 2024 · 0 comments

Comments

@GabrielLomba
Copy link

Hi! This dialect relies on SF connection error event emissions. However, the default SF SDK Connection class does not emit them (I created an issue on their repo as well related to this confusing behavior). This means bad connections will still be kept in the pool since the validateConnection implementation is rather simple.

A better validateConnection implementation could make use of the isValidAsync SDK method which will verify if the connection is up and do a heartbeat to ensure it's ready to receive queries. I'm willing to submit a PR to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant