Black text on black background

[sbadux]

The menu texts are black on a black background. This happens in Ubuntu 18.10 and it may be related to the Ubuntu theme. I've the default Ubuntu theme so I think this should be fixed if possible.

EDIT: I'm talking about the black bar under the Title Bar. In this bar there are the "hidden" menu buttons

[ralphtheninja]

Hmm interesting, is this only due to Ubuntu 18.10?

[sbadux]

I don't know because I've never used DeltaChat Desktop v1.5 on Ubuntu 18.04. Today I've upgraded to 18.10 and THEN installed the DC v.1.5. If you haven't done any change that could have caused this problem, I can suppose that it's related to the new Yaru theme https://github.com/ubuntu/yaru

[Jikstra]

This is because of your GTK theme but I remeber that there were very similiar problems with atom editor and electron not changing menu colors. I'm not sure, but i think it was an GTK2/GTK3 problem. @ralphtheninja are we using an electron framework which is using GTK2 or 3?
electron/electron#2927

[ralphtheninja]

We use electron v2, have no idea about gtk.

[Jikstra]

It's possible that this is fixed as soon as we switch to electron v3.

[Jikstra]

@sbadux can you test out latest master with electron v3? Don't have a ubuntu running :/ For me dark gtk themes work, but they also worked with electron v2.

[sbadux]

@sbadux can you test out latest master with electron v3? Don't have a ubuntu running :/ For me dark gtk themes work, but they also worked with electron v2.

I can test it, but I don't know how to do the test. I'm not a developer so I really don't know what I should do. Can you please explain me how to do this test?

[r10s]

on ubuntu 18.04 with standard theme the menu looks okay

[Jikstra]

I can test it, but I don't know how to do the test. I'm not a developer so I really don't know what I should do. Can you please explain me how to do this test?

No problem, we are currently thinking of doing a new release with binaries today/tomorrow, so it's a lot easier to install than trying to compile/build it on your own which also isn't hard but maybe harder :D

But if you have irc or any chat application (also deltachat would work ^^) i can lead you through all those things.

[Jikstra]

@r10s okay you're using the "old" theme. Just to show the difference:
https://i.redd.it/cljbq1bqsqt11.png

Source: https://www.reddit.com/r/linux/comments/9qe0yn/ubuntu_with_and_without_yaru_communitheme_is/

[ralphtheninja]

Missing a lot of German translations ;)

[ralphtheninja]

@sbadux You can try a new release here https://github.com/deltachat/deltachat-desktop/releases/tag/v1.6.0 , hopefully switching to electron 3 fixes your problem

[sbadux]

Thanks a lot for the new .deb :-)
The bar is still back, but I noticed that it turns black only when the windows has the focus. The menus are readable if I click on the desktop o focus another window.

https://youtu.be/0J4D6tu4ZDs

[ralphtheninja]

I'm wondering if this is related:

deltachat-desktop/src/main/windows/main.js

Line 34 in 63119bb

darkTheme: true, // Forces dark theme (GTK+3)

[Jikstra]

I'm not really through all the info, but maybe this helps:
electron/electron#13381
ubuntu/yaru#715

It's possible that this is an electron or yaru bug.

This is also interesting, it seems to be possible to figure out if the system is using a dark theme or not:
https://medium.com/missive-app/make-your-electron-app-dark-mode-compatible-c23dcfdd0dfa

[ralphtheninja]

Just updated to Ubuntu 18.10 and I can reproduce when using the Yaru theme. However, I have no idea of how to fix it. The darkTheme property doesn't make any difference.

[okdistribute]

On the latest release, let us know if you still see this bug @sbadux . I think we are going to retire it though in favor of more pressing fixes at the moment