Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting to transfer a directory error does not exit on the receiving peer #7

Open
jakehemmerle opened this issue Feb 14, 2021 · 1 comment

Comments

@jakehemmerle
Copy link

First of all, I fucking love the simplicity of this app. I just transferred some files between two computers and it was so simple. Thank you for making it.


On the sending side, the peers connect and authenticate, then I get the error:

Peer connected and authenticated!
Error transferring file read BraveSoftware: is a directory

Then, the sending side exits.

On the receiving side, I receive no error.

Looking for peer camp-match-exhaust-fire...
Peer connected and authenticated!

and it does not close.

It seems the following behavior should be expected:

  1. pcp should either wrap/compress/file-ify the folder before sending (and unwrap it on the receiving side)
  2. pcp should throw an error as soon as it sees the input is a folder, before it connects and authenticates to the peer.
@dennis-tra
Copy link
Owner

dennis-tra commented Feb 14, 2021

Hi @jakehemmerle ,

awesome that you're checking out the tool :)

Today I created a couple of work items that I want to address for a 1.0 release (list is not yet complete). I just moved the Folder Transmission card up in the priority.

I'm definitely planning to add the ability to transfer directories so I think your point 2. would be the quick fix and your point 1. the proper feature.

Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants