Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node:fs cp support #20803

Closed
catuhana opened this issue Oct 5, 2023 · 0 comments · Fixed by #21745
Closed

node:fs cp support #20803

catuhana opened this issue Oct 5, 2023 · 0 comments · Fixed by #21745
Labels
bug Something isn't working node compat

Comments

@catuhana
Copy link
Contributor

catuhana commented Oct 5, 2023

https://nodejs.org/dist/latest-v18.x/docs/api/fs.html#fscpsrc-dest-options-callback

Some Node CLI tools are using it, like discord.js' create-discord-bot package, which causes discordjs/discord.js#9810.
@bartlomieju bartlomieju added bug Something isn't working node compat labels Oct 5, 2023
@littledivy littledivy mentioned this issue Dec 31, 2023
Merged
littledivy added a commit that referenced this issue Jan 5, 2024
@littledivy
fix(ext/node): add fs.cp, fs.cpSync, promises.cp (#21745)
df062d2 
Fixes #20803
Fixes #21723

Performance: copying a 48GiB rust `target` folder (recursive)
| Platform  | `deno` | `node v21.5` | Improvement |
| -------- | ------- | ------- | ------- |
| macOS (APFS) |   3.1secs  |  127.99 secs |  **42x** |
| Windows | 18.3secs | 67.2secs |  **3.8x** |

Copying files with varying sizes:


![image](https://github.com/denoland/deno/assets/34997667/58932652-6f7a-47f5-8504-896dc9ab4ddc)
bartlomieju pushed a commit that referenced this issue Jan 12, 2024
@littledivy @bartlomieju
fix(ext/node): add fs.cp, fs.cpSync, promises.cp (#21745)
1fcace1 
Fixes #20803
Fixes #21723

Performance: copying a 48GiB rust `target` folder (recursive)
| Platform  | `deno` | `node v21.5` | Improvement |
| -------- | ------- | ------- | ------- |
| macOS (APFS) |   3.1secs  |  127.99 secs |  **42x** |
| Windows | 18.3secs | 67.2secs |  **3.8x** |

Copying files with varying sizes:


![image](https://github.com/denoland/deno/assets/34997667/58932652-6f7a-47f5-8504-896dc9ab4ddc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working node compat
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ext/node): add fs.cp, fs.cpSync, promises.cp littledivy/deno
2 participants
@bartlomieju @catuhana